Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-2289 - changes/additions to nav to support promotions #2210

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

rossedfort
Copy link
Contributor

@rossedfort rossedfort commented Jul 16, 2024

Description & motivation 💭

https://www.figma.com/design/8dSoDU2sWeQf7CgZzTqzeW/Cloud-Account-Management?node-id=10444-4172&m=dev
Adds support for new nav callout for promotions

  • add navigation badge component
  • add dollar badge icon
  • expose a slot in side-nav component
  • adjust nav width to new designs

Screenshots (if applicable) 📸

expanded collapsed
default Screenshot 2024-07-16 at 11 44 57 AM Screenshot 2024-07-16 at 11 45 41 AM
hover Screenshot 2024-07-16 at 11 45 21 AM Screenshot 2024-07-16 at 11 54 07 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

- add navigation badge component
- add dollar badge icon
- expose a slot in side-nav component
- adjust nav width to new designs
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 5:50pm

@rossedfort rossedfort merged commit b04945a into main Jul 16, 2024
11 checks passed
@rossedfort rossedfort deleted the DT-2289-navigation-badge-summer-promo branch July 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants